SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.0.4

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
433 107 0 0

Files

Class Bugs
com.hcl.domino.admin.AbstractGroup 1
com.hcl.domino.keep.LaunchHandler 1
com.hcl.domino.keep.admin.GetGroup 1
com.hcl.domino.keep.cache.impl.KeepApplicationCacheHolder 2
com.hcl.domino.keep.config.KeepConfigHolder 3
com.hcl.domino.keep.dbfunctions.CalendarFunctions 1
com.hcl.domino.keep.dbrequests.KeepJnxSession 1
com.hcl.domino.keep.dbrequests.data.CreateDocumentAttachment 1
com.hcl.domino.keep.dbrequests.data.GetDocumentAttachment 1
com.hcl.domino.keep.dbrequests.data.UpdateDocument 1
com.hcl.domino.keep.dbrequests.designcode.CreateNSF 1
com.hcl.domino.keep.dbrequests.designcode.ExecuteAgent 1
com.hcl.domino.keep.dbrequests.designcode.ExecuteAgentWithContext 1
com.hcl.domino.keep.dbrequests.designcode.RunFormula 1
com.hcl.domino.keep.dbrequests.designcode.UpdateCreateForm 1
com.hcl.domino.keep.dbrequests.designcode.UpdateCreateView 1
com.hcl.domino.keep.dbrequests.pim.CreateMessage 1
com.hcl.domino.keep.dbrequests.pim.CreateRule 1
com.hcl.domino.keep.dbrequests.pim.DeleteLabel 1
com.hcl.domino.keep.dbrequests.pim.GetAddressLookupSimple$DbAndId 1
com.hcl.domino.keep.dbrequests.pim.GetMessageBody 1
com.hcl.domino.keep.dbrequests.pim.GetMimeMessage 2
com.hcl.domino.keep.dbrequests.pim.GetTaskList 1
com.hcl.domino.keep.dbrequests.pim.LabelHelper 1
com.hcl.domino.keep.dbrequests.pim.LookupUserInfo 1
com.hcl.domino.keep.dbrequests.pim.RulesHelper 15
com.hcl.domino.keep.dbrequests.pim.UpdateRule 1
com.hcl.domino.keep.dbrequests.pim.mapper.CalendarMapper 1
com.hcl.domino.keep.dbrequests.pim.mapper.DominoJMapperDefault$MapHelper 1
com.hcl.domino.keep.dbrequests.pim.mapper.TaskMapper 1
com.hcl.domino.keep.eventbus.KeepSubscriber 1
com.hcl.domino.keep.exceptions.ErrorClassification 1
com.hcl.domino.keep.handlers.core.AbstractAPIHandler 2
com.hcl.domino.keep.handlers.core.FetchOdata 1
com.hcl.domino.keep.handlers.core.FetchOdataList 1
com.hcl.domino.keep.handlers.core.GetDesign 1
com.hcl.domino.keep.handlers.core.GetDxl 1
com.hcl.domino.keep.handlers.core.GetOdataMetadata 1
com.hcl.domino.keep.handlers.pim.GetMailAttachment 1
com.hcl.domino.keep.platform.ConfigLoader 3
com.hcl.domino.keep.platform.DominoXMLDesign 2
com.hcl.domino.keep.platform.InflightController$InflightInfo 1
com.hcl.domino.keep.platform.KeepJSHelper 2
com.hcl.domino.keep.saml.CertBuilder 1
com.hcl.domino.keep.saml.KeepSAML 2
com.hcl.domino.keep.saml.KeepSAMLConstants 15
com.hcl.domino.keep.saml.KeepSAMLTemplate 2
com.hcl.domino.keep.saml.PemHolder 3
com.hcl.domino.keep.saml.SAMLXmlUtils 2
com.hcl.domino.keep.saml.SamlDescriptorBuilder 1
com.hcl.domino.keep.saml.UserInfo 1
com.hcl.domino.keep.security.BasicHandler 1
com.hcl.domino.keep.security.JwtManagerHolder 3
com.hcl.domino.keep.tools.KeepMustacheHelper 2
com.hcl.domino.keep.tools.KeepUtils 2
com.hcl.domino.keep.tools.MimeHelper 2
com.hcl.domino.keep.tools.SimpleXMLDoc 2
com.hcl.domino.keep.tools.SimpleXMLDoc$Element 1
com.hcl.domino.keep.verticles.AgentSchedulerServiceVerticle 1

com.hcl.domino.admin.AbstractGroup

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive com.hcl.domino.admin.AbstractGroup.resolveRecursive(KeepJnxSession, String, TreeSet, ArrayList, TreeSet, Map) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 344 High

com.hcl.domino.keep.LaunchHandler

Bug Category Details Line Priority
Exceptional return value of java.io.File.delete() ignored in com.hcl.domino.keep.LaunchHandler.prepareForDebug(boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 474 Medium

com.hcl.domino.keep.admin.GetGroup

Bug Category Details Line Priority
Redundant nullcheck of note, which is known to be non-null in com.hcl.domino.keep.admin.GetGroup.process(DbRequestParameters) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 57 Medium

com.hcl.domino.keep.cache.impl.KeepApplicationCacheHolder

Bug Category Details Line Priority
com.hcl.domino.keep.cache.impl.KeepApplicationCacheHolder.setBarbican(TheBarbican) unconditionally sets the field barbican BAD_PRACTICE ME_ENUM_FIELD_SETTER 136 Medium
Null passed for non-null parameter of new com.hcl.domino.keep.security.TheBarbican(KeepDbInfo) in com.hcl.domino.keep.cache.impl.KeepApplicationCacheHolder.getBarbican() CORRECTNESS NP_NONNULL_PARAM_VIOLATION 119 High

com.hcl.domino.keep.config.KeepConfigHolder

Bug Category Details Line Priority
com.hcl.domino.keep.config.KeepConfigHolder.setPimConfig(JsonObject) unconditionally sets the field pimConfig BAD_PRACTICE ME_ENUM_FIELD_SETTER 274 Medium
com.hcl.domino.keep.config.KeepConfigHolder.setSystemUserName(String) unconditionally sets the field systemUserName BAD_PRACTICE ME_ENUM_FIELD_SETTER 280 Medium
Redundant nullcheck of candidate, which is known to be non-null in com.hcl.domino.keep.config.KeepConfigHolder.getAllKeepApiInfo(String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 149 Medium

com.hcl.domino.keep.dbfunctions.CalendarFunctions

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.dbfunctions.CalendarFunctions.getBase64URLEncoded(String): String.getBytes() I18N DM_DEFAULT_ENCODING 759 High

com.hcl.domino.keep.dbrequests.KeepJnxSession

Bug Category Details Line Priority
Nullcheck of fields at line 385 of value previously dereferenced in com.hcl.domino.keep.dbrequests.KeepJnxSession.document2JsonSelected(Document, Set, String, Map) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 373 Medium

com.hcl.domino.keep.dbrequests.data.CreateDocumentAttachment

Bug Category Details Line Priority
Exceptional return value of java.io.File.delete() ignored in com.hcl.domino.keep.dbrequests.data.CreateDocumentAttachment.process(DbRequestParameters) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 116 Medium

com.hcl.domino.keep.dbrequests.data.GetDocumentAttachment

Bug Category Details Line Priority
com.hcl.domino.keep.dbrequests.data.GetDocumentAttachment.process(DbRequestParameters) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 65 Medium

com.hcl.domino.keep.dbrequests.data.UpdateDocument

Bug Category Details Line Priority
Redundant nullcheck of note, which is known to be non-null in com.hcl.domino.keep.dbrequests.data.UpdateDocument.process(DbRequestParameters) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 55 Medium

com.hcl.domino.keep.dbrequests.designcode.CreateNSF

Bug Category Details Line Priority
Return value of com.hcl.domino.DominoClient.createDatabase(String, String, boolean, boolean, DominoClient$Encryption) ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 121 Medium

com.hcl.domino.keep.dbrequests.designcode.ExecuteAgent

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in com.hcl.domino.keep.dbrequests.designcode.ExecuteAgent.process(DbRequestParameters) STYLE REC_CATCH_EXCEPTION 141 Medium

com.hcl.domino.keep.dbrequests.designcode.ExecuteAgentWithContext

Bug Category Details Line Priority
Redundant nullcheck of doc, which is known to be non-null in com.hcl.domino.keep.dbrequests.designcode.ExecuteAgentWithContext.process(DbRequestParameters) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 70 Medium

com.hcl.domino.keep.dbrequests.designcode.RunFormula

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in com.hcl.domino.keep.dbrequests.designcode.RunFormula.process(DbRequestParameters) STYLE REC_CATCH_EXCEPTION 140 Medium

com.hcl.domino.keep.dbrequests.designcode.UpdateCreateForm

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.dbrequests.designcode.UpdateCreateForm.process(DbRequestParameters): java.io.ByteArrayOutputStream.toString() I18N DM_DEFAULT_ENCODING 87 High

com.hcl.domino.keep.dbrequests.designcode.UpdateCreateView

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.dbrequests.designcode.UpdateCreateView.process(DbRequestParameters): java.io.ByteArrayOutputStream.toString() I18N DM_DEFAULT_ENCODING 121 High

com.hcl.domino.keep.dbrequests.pim.CreateMessage

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.dbrequests.pim.CreateMessage.process(DbRequestParameters): new String(byte[]) I18N DM_DEFAULT_ENCODING 174 High

com.hcl.domino.keep.dbrequests.pim.CreateRule

Bug Category Details Line Priority
Comparison of String objects using == or != in com.hcl.domino.keep.dbrequests.pim.CreateRule.process(DbRequestParameters) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 109 High

com.hcl.domino.keep.dbrequests.pim.DeleteLabel

Bug Category Details Line Priority
Boxed value is unboxed and then immediately reboxed in com.hcl.domino.keep.dbrequests.pim.DeleteLabel.lambda$process$0(DbRequestParameters, AtomicInteger, JsonArray, Integer) PERFORMANCE BX_UNBOXING_IMMEDIATELY_REBOXED 87 Medium

com.hcl.domino.keep.dbrequests.pim.GetAddressLookupSimple$DbAndId

Bug Category Details Line Priority
Should com.hcl.domino.keep.dbrequests.pim.GetAddressLookupSimple$DbAndId be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 86-95 Medium

com.hcl.domino.keep.dbrequests.pim.GetMessageBody

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.dbrequests.pim.GetMessageBody.docWrite2Html(DominoClient, Document, ResponseSubscriberOutputStream): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 76 High

com.hcl.domino.keep.dbrequests.pim.GetMimeMessage

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.dbrequests.pim.GetMimeMessage.process(DbRequestParameters): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 67 High
Exception is caught when Exception is not thrown in com.hcl.domino.keep.dbrequests.pim.GetMimeMessage.process(DbRequestParameters) STYLE REC_CATCH_EXCEPTION 90 Medium

com.hcl.domino.keep.dbrequests.pim.GetTaskList

Bug Category Details Line Priority
Possible null pointer dereference of com.hcl.domino.keep.dbrequests.DbRequestParameters.incoming in com.hcl.domino.keep.dbrequests.pim.GetTaskList.process(DbRequestParameters) CORRECTNESS NP_NULL_ON_SOME_PATH 70 Medium

com.hcl.domino.keep.dbrequests.pim.LabelHelper

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.dbrequests.pim.LabelHelper.getBase64Encoded(String): String.getBytes() I18N DM_DEFAULT_ENCODING 142 High

com.hcl.domino.keep.dbrequests.pim.LookupUserInfo

Bug Category Details Line Priority
Dead store to userCache in com.hcl.domino.keep.dbrequests.pim.LookupUserInfo.checkCacheByEmail(String) STYLE DLS_DEAD_LOCAL_STORE 217 Medium

com.hcl.domino.keep.dbrequests.pim.RulesHelper

Bug Category Details Line Priority
Dead store to tempTokExtra in com.hcl.domino.keep.dbrequests.pim.RulesHelper.addRule(String) STYLE DLS_DEAD_LOCAL_STORE 311 Medium
Dead store to $L14 in com.hcl.domino.keep.dbrequests.pim.RulesHelper.disableRule(DominoClient, String) STYLE DLS_DEAD_LOCAL_STORE 401 Medium
Dead store to $L13 in com.hcl.domino.keep.dbrequests.pim.RulesHelper.enableRule(DominoClient, String) STYLE DLS_DEAD_LOCAL_STORE 486 Medium
Boxing/unboxing to parse a primitive com.hcl.domino.keep.dbrequests.pim.RulesHelper.buildActionFormula() PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 570 High
Primitive boxed just to call toString in com.hcl.domino.keep.dbrequests.pim.RulesHelper.buildActionFormula() PERFORMANCE DM_BOXED_PRIMITIVE_TOSTRING 570 Medium
com.hcl.domino.keep.dbrequests.pim.RulesHelper.buildActionFormula() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 570 Medium
com.hcl.domino.keep.dbrequests.pim.RulesHelper.buildActionFormula() invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead PERFORMANCE DM_NUMBER_CTOR 570 Medium
com.hcl.domino.keep.dbrequests.pim.RulesHelper.disableRule(DominoClient, String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead PERFORMANCE DM_NUMBER_CTOR 383 Medium
com.hcl.domino.keep.dbrequests.pim.RulesHelper.enableRule(DominoClient, String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead PERFORMANCE DM_NUMBER_CTOR 477 Medium
com.hcl.domino.keep.dbrequests.pim.RulesHelper.addAction(String) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 163 Medium
com.hcl.domino.keep.dbrequests.pim.RulesHelper.addRule(String) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 302 Medium
Comparison of String objects using == or != in com.hcl.domino.keep.dbrequests.pim.RulesHelper.addRule(String) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 310 High
com.hcl.domino.keep.dbrequests.pim.RulesHelper.addAction(String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 186 Medium
com.hcl.domino.keep.dbrequests.pim.RulesHelper.buildRuleFormula() concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 632 Medium
com.hcl.domino.keep.dbrequests.pim.RulesHelper.specialHandling(HashMap) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 1042 Medium

com.hcl.domino.keep.dbrequests.pim.UpdateRule

Bug Category Details Line Priority
Dead store to condList in com.hcl.domino.keep.dbrequests.pim.UpdateRule.updateConditionAction(RulesHelper, JsonObject, Document) STYLE DLS_DEAD_LOCAL_STORE 222 Medium

com.hcl.domino.keep.dbrequests.pim.mapper.CalendarMapper

Bug Category Details Line Priority
Dead store to action in com.hcl.domino.keep.dbrequests.pim.mapper.CalendarMapper.iterateOnAlert(JsonObject, String, JsonObject) STYLE DLS_DEAD_LOCAL_STORE 645 Medium

com.hcl.domino.keep.dbrequests.pim.mapper.DominoJMapperDefault$MapHelper

Bug Category Details Line Priority
Should com.hcl.domino.keep.dbrequests.pim.mapper.DominoJMapperDefault$MapHelper be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 50-56 Medium

com.hcl.domino.keep.dbrequests.pim.mapper.TaskMapper

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.dbrequests.pim.mapper.TaskMapper.getBase64URLEncoded(String): String.getBytes() I18N DM_DEFAULT_ENCODING 154 High

com.hcl.domino.keep.eventbus.KeepSubscriber

Bug Category Details Line Priority
Unread public/protected field: com.hcl.domino.keep.eventbus.KeepSubscriber.c STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 36 Medium

com.hcl.domino.keep.exceptions.ErrorClassification

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive com.hcl.domino.keep.exceptions.ErrorClassification.getValue() PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 93 High

com.hcl.domino.keep.handlers.core.AbstractAPIHandler

Bug Category Details Line Priority
Return value of io.reactivex.Observable.subscribe(Consumer, Consumer, Action) ignored in com.hcl.domino.keep.handlers.core.AbstractAPIHandler.listenForBufferResponse(EventBusRequestObservable, RoutingContext) CORRECTNESS RV_RETURN_VALUE_IGNORED 643 Medium
Return value of io.reactivex.Observable.subscribe(Consumer, Consumer, Action) ignored in com.hcl.domino.keep.handlers.core.AbstractAPIHandler.listenForJsonResponse(EventBusRequestObservable, RoutingContext) CORRECTNESS RV_RETURN_VALUE_IGNORED 680 Medium

com.hcl.domino.keep.handlers.core.FetchOdata

Bug Category Details Line Priority
Return value of io.reactivex.Observable.subscribe(Consumer, Consumer, Action) ignored in com.hcl.domino.keep.handlers.core.FetchOdata.listenForResponse(EventBusRequestObservable, RoutingContext) CORRECTNESS RV_RETURN_VALUE_IGNORED 148 Medium

com.hcl.domino.keep.handlers.core.FetchOdataList

Bug Category Details Line Priority
Return value of io.reactivex.Observable.subscribe(Consumer, Consumer, Action) ignored in com.hcl.domino.keep.handlers.core.FetchOdataList.listenForResponse(EventBusRequestObservable, RoutingContext) CORRECTNESS RV_RETURN_VALUE_IGNORED 44 Medium

com.hcl.domino.keep.handlers.core.GetDesign

Bug Category Details Line Priority
Return value of io.reactivex.Observable.subscribe(Consumer, Consumer, Action) ignored in com.hcl.domino.keep.handlers.core.GetDesign.listenForResponse(EventBusRequestObservable, RoutingContext) CORRECTNESS RV_RETURN_VALUE_IGNORED 59 Medium

com.hcl.domino.keep.handlers.core.GetDxl

Bug Category Details Line Priority
Return value of io.reactivex.Observable.subscribe(Consumer, Consumer, Action) ignored in com.hcl.domino.keep.handlers.core.GetDxl.listenForResponse(EventBusRequestObservable, RoutingContext) CORRECTNESS RV_RETURN_VALUE_IGNORED 43 Medium

com.hcl.domino.keep.handlers.core.GetOdataMetadata

Bug Category Details Line Priority
Return value of io.reactivex.Observable.subscribe(Consumer, Consumer, Action) ignored in com.hcl.domino.keep.handlers.core.GetOdataMetadata.listenForResponse(EventBusRequestObservable, RoutingContext) CORRECTNESS RV_RETURN_VALUE_IGNORED 48 Medium

com.hcl.domino.keep.handlers.pim.GetMailAttachment

Bug Category Details Line Priority
Return value of io.reactivex.Observable.subscribe(Consumer, Consumer, Action) ignored in com.hcl.domino.keep.handlers.pim.GetMailAttachment.listenForResponse(EventBusRequestObservable, RoutingContext) CORRECTNESS RV_RETURN_VALUE_IGNORED 59 Medium

com.hcl.domino.keep.platform.ConfigLoader

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in com.hcl.domino.keep.platform.ConfigLoader.extractDXL(DominoClient, String, File) STYLE REC_CATCH_EXCEPTION 334 Medium
Exception is caught when Exception is not thrown in com.hcl.domino.keep.platform.ConfigLoader.runCreateDB(DominoClient, Database, String) STYLE REC_CATCH_EXCEPTION 497 Medium
Exceptional return value of java.io.File.delete() ignored in com.hcl.domino.keep.platform.ConfigLoader.runRemoveDbDesign() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 679 Medium

com.hcl.domino.keep.platform.DominoXMLDesign

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.platform.DominoXMLDesign.getRaw(): java.io.ByteArrayOutputStream.toString() I18N DM_DEFAULT_ENCODING 130 High
Found reliance on default encoding in com.hcl.domino.keep.platform.DominoXMLDesign.loadXMLFromString(String): String.getBytes() I18N DM_DEFAULT_ENCODING 249 High

com.hcl.domino.keep.platform.InflightController$InflightInfo

Bug Category Details Line Priority
Should com.hcl.domino.keep.platform.InflightController$InflightInfo be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 49-73 Medium

com.hcl.domino.keep.platform.KeepJSHelper

Bug Category Details Line Priority
Unread public/protected field: com.hcl.domino.keep.platform.KeepJSHelper.document STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 35 Medium
Unread public/protected field: com.hcl.domino.keep.platform.KeepJSHelper.view STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 36 Medium

com.hcl.domino.keep.saml.CertBuilder

Bug Category Details Line Priority
Unread field: com.hcl.domino.keep.saml.CertBuilder.keyLenght; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 111 Medium

com.hcl.domino.keep.saml.KeepSAML

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.saml.KeepSAML.getUserIDFromVault(String, String): String.getBytes() I18N DM_DEFAULT_ENCODING 270 High
Redundant nullcheck of com.hcl.domino.keep.saml.UserInfo.idFileName which is known to be null in com.hcl.domino.keep.saml.KeepSAML.getUserIDFromVault(String, String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE 263 Medium

com.hcl.domino.keep.saml.KeepSAMLConstants

Bug Category Details Line Priority
com.hcl.domino.keep.saml.KeepSAMLConstants.ASSERT_TAG isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 34 High
com.hcl.domino.keep.saml.KeepSAMLConstants.AUDIENCE_TAG isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 44 High
com.hcl.domino.keep.saml.KeepSAMLConstants.CONDITIONS_TAG isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 39 High
com.hcl.domino.keep.saml.KeepSAMLConstants.NAMEID_TAG isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 36 High
com.hcl.domino.keep.saml.KeepSAMLConstants.NOT_BEFORE isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 64 High
com.hcl.domino.keep.saml.KeepSAMLConstants.NOT_ON_OR_AFTER isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 63 High
com.hcl.domino.keep.saml.KeepSAMLConstants.RECIPIENT isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 65 High
com.hcl.domino.keep.saml.KeepSAMLConstants.REQUEST_TAG isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 43 High
com.hcl.domino.keep.saml.KeepSAMLConstants.SAML_ASSERT_EXPIRATION_MS isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 81 High
com.hcl.domino.keep.saml.KeepSAMLConstants.SAML_DEST_NAME isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 57 High
com.hcl.domino.keep.saml.KeepSAMLConstants.SAML_ID_ATTR_NAME isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 53 High
com.hcl.domino.keep.saml.KeepSAMLConstants.SAML_ISSUE_NAME isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 56 High
com.hcl.domino.keep.saml.KeepSAMLConstants.SAML_REQ_URL_NAME isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 58 High
com.hcl.domino.keep.saml.KeepSAMLConstants.SAML_RESPTO_NAME isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 54 High
com.hcl.domino.keep.saml.KeepSAMLConstants.SUBJECT_C_DATA_TAG isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 38 High

com.hcl.domino.keep.saml.KeepSAMLTemplate

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.saml.KeepSAMLTemplate.generateAssertion(UserInfo): String.getBytes() I18N DM_DEFAULT_ENCODING 73 High
Exception is caught when Exception is not thrown in com.hcl.domino.keep.saml.KeepSAMLTemplate.generateAssertion(UserInfo) STYLE REC_CATCH_EXCEPTION 198 Medium

com.hcl.domino.keep.saml.PemHolder

Bug Category Details Line Priority
new com.hcl.domino.keep.saml.PemHolder(byte[], byte[], byte[]) may expose internal representation by storing an externally mutable object into PemHolder.certBytes MALICIOUS_CODE EI_EXPOSE_REP2 97 Medium
new com.hcl.domino.keep.saml.PemHolder(byte[], byte[], byte[]) may expose internal representation by storing an externally mutable object into PemHolder.privateKeyBytes MALICIOUS_CODE EI_EXPOSE_REP2 95 Medium
new com.hcl.domino.keep.saml.PemHolder(byte[], byte[], byte[]) may expose internal representation by storing an externally mutable object into PemHolder.publicKeyBytes MALICIOUS_CODE EI_EXPOSE_REP2 96 Medium

com.hcl.domino.keep.saml.SAMLXmlUtils

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.saml.SAMLXmlUtils.getX509Certificate(String): String.getBytes() I18N DM_DEFAULT_ENCODING 100 High
Exception is caught when Exception is not thrown in com.hcl.domino.keep.saml.SAMLXmlUtils.signAssertion(Element, Document, String, String, String, String) STYLE REC_CATCH_EXCEPTION 280 Medium

com.hcl.domino.keep.saml.SamlDescriptorBuilder

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.saml.SamlDescriptorBuilder.build(): java.io.ByteArrayOutputStream.toString() I18N DM_DEFAULT_ENCODING 86 High

com.hcl.domino.keep.saml.UserInfo

Bug Category Details Line Priority
Unread public/protected field: com.hcl.domino.keep.saml.UserInfo.dominoName STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 400 Medium

com.hcl.domino.keep.security.BasicHandler

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.security.BasicHandler.handle(RoutingContext): new String(byte[]) I18N DM_DEFAULT_ENCODING 98 High

com.hcl.domino.keep.security.JwtManagerHolder

Bug Category Details Line Priority
com.hcl.domino.keep.security.JwtManagerHolder.initializeAuthprovider(Vertx, JsonObject) unconditionally sets the field config BAD_PRACTICE ME_ENUM_FIELD_SETTER 225 Medium
com.hcl.domino.keep.security.JwtManagerHolder.setAuthProvider(JWTAuth) unconditionally sets the field authProvider BAD_PRACTICE ME_ENUM_FIELD_SETTER 243 Medium
com.hcl.domino.keep.security.JwtManagerHolder.setAuthProvider(JWTAuth) unconditionally sets the field internalAuthProvider BAD_PRACTICE ME_ENUM_FIELD_SETTER 244 Medium

com.hcl.domino.keep.tools.KeepMustacheHelper

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.tools.KeepMustacheHelper.execute(JsonObject, OutputStream): new java.io.PrintWriter(OutputStream) I18N DM_DEFAULT_ENCODING 89 High
Found reliance on default encoding in com.hcl.domino.keep.tools.KeepMustacheHelper.getMustache(): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 219 High

com.hcl.domino.keep.tools.KeepUtils

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.tools.KeepUtils.getMapFromResource(String, String): new java.util.Scanner(InputStream) I18N DM_DEFAULT_ENCODING 456 High
Possible null pointer dereference in com.hcl.domino.keep.tools.KeepUtils.loadConfiguration(Vertx, String) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 647 Medium

com.hcl.domino.keep.tools.MimeHelper

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.tools.MimeHelper.json2Mime(JsonObject, Collection, String, String): java.io.ByteArrayOutputStream.toString() I18N DM_DEFAULT_ENCODING 317 High
Comparison of String parameter using == or != in com.hcl.domino.keep.tools.MimeHelper.docMime2Stream(DominoClient, Document, String, int, OutputStream) BAD_PRACTICE ES_COMPARING_PARAMETER_STRING_WITH_EQ 207 High

com.hcl.domino.keep.tools.SimpleXMLDoc

Bug Category Details Line Priority
Found reliance on default encoding in com.hcl.domino.keep.tools.SimpleXMLDoc.initializeDoc(): new java.io.PrintWriter(OutputStream) I18N DM_DEFAULT_ENCODING 441 High
Call to method of static java.text.DateFormat in com.hcl.domino.keep.tools.SimpleXMLDoc.dateElement(SimpleXMLDoc$Element, Date) MT_CORRECTNESS STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE 316 Medium

com.hcl.domino.keep.tools.SimpleXMLDoc$Element

Bug Category Details Line Priority
Should com.hcl.domino.keep.tools.SimpleXMLDoc$Element be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 60-107 Medium

com.hcl.domino.keep.verticles.AgentSchedulerServiceVerticle

Bug Category Details Line Priority
Return value of com.hcl.domino.DominoClient.runInterruptable(Callable, DominoClient$IBreakHandler) ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 193 Medium